Update circuits.js tests and run in CI#167
Conversation
|
Have some similar changes + fixes in #172 maybe we should merge into here? |
|
If you think this one is good, I'd merge to master first, and then get yours on top of it on master. |
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
Other than the formatting, looks good to me.
| command: build foundation | ||
|
|
||
| aztec-js: | ||
| aztec-js: |
There was a problem hiding this comment.
This seems to be a typo. The space should not be there.
| 2, | ||
| ); | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
Prettier should put a line at the end of files so this change seems to be caused by incorrect formatting. We should probably configure prettier so that it throws an error instead of warning so that we keep the formatting coherent across codebase.
There was a problem hiding this comment.
should probably add yarn formatting as a preCommit step
There was a problem hiding this comment.
Hmm I'm running the formatter in circuits.js locally and it's not complaining, and the CI is not reporting any warnings either (see here).
~/Projects/aztec3-packages/yarn-project/circuits.js (palla/circuits-tests-ci)$ yarn formatting
Checking formatting...
All matched files use Prettier code style!
* feat: partial logic to check existence of vk in contract tree (missing merkle tree membership calls) * fix private call data * perform sibling-path traversal/hashing to get from VKhash/function-leaf all the way to function root and then to contract root --------- Co-authored-by: dbanks12 <david@aztecprotocol.com>
* feat: partial logic to check existence of vk in contract tree (missing merkle tree membership calls) * fix private call data * perform sibling-path traversal/hashing to get from VKhash/function-leaf all the way to function root and then to contract root --------- Co-authored-by: dbanks12 <david@aztecprotocol.com>
* feat: partial logic to check existence of vk in contract tree (missing merkle tree membership calls) * fix private call data * perform sibling-path traversal/hashing to get from VKhash/function-leaf all the way to function root and then to contract root --------- Co-authored-by: dbanks12 <david@aztecprotocol.com>
3 participants
Fixes some circuits tests, skips others, and adds them to CI